Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: ak.argcombinations, ak.combinations #1307

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Feb 22, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1307 (589b4e7) into main (5613d44) will increase coverage by 0.07%.
The diff coverage is 77.77%.

Impacted Files Coverage Δ
...ard/_v2/operations/structure/ak_argcombinations.py 76.92% <70.00%> (+1.92%) ⬆️
...wkward/_v2/operations/structure/ak_combinations.py 90.90% <87.50%> (+15.90%) ⬆️
src/awkward/_v2/contents/listoffsetarray.py 80.55% <0.00%> (+0.13%) ⬆️
src/awkward/_v2/contents/indexedoptionarray.py 86.77% <0.00%> (+0.16%) ⬆️
src/awkward/_v2/contents/listarray.py 88.23% <0.00%> (+0.21%) ⬆️
src/awkward/_v2/contents/content.py 81.78% <0.00%> (+0.31%) ⬆️
src/awkward/_v2/contents/regulararray.py 83.81% <0.00%> (+0.81%) ⬆️
src/awkward/_v2/operations/structure/ak_argsort.py 100.00% <0.00%> (+25.00%) ⬆️

@ioanaif ioanaif requested a review from jpivarski February 22, 2022 23:45
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I guess combinations was already implemented as a layout method, and just needed to be passed through to highlevel (and tested)? It's great to know that it's tested now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants