Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: ak.unflatten #1360

Merged
merged 5 commits into from
Mar 17, 2022
Merged

C++ refactoring: ak.unflatten #1360

merged 5 commits into from
Mar 17, 2022

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Mar 10, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1360 (f8dac2f) into main (b2fd2be) will decrease coverage by 0.66%.
The diff coverage is 59.54%.

❗ Current head f8dac2f differs from pull request most recent head 1174b6a. Consider uploading reports for the commit 1174b6a to get more accurate results

Impacted Files Coverage Δ
src/awkward/_v2/_connect/cling.py 0.00% <ø> (ø)
src/awkward/_v2/_lookup.py 97.50% <0.00%> (ø)
src/awkward/_v2/_prettyprint.py 66.09% <0.00%> (+2.29%) ⬆️
src/awkward/_v2/_typetracer.py 69.14% <0.00%> (ø)
src/awkward/_v2/forms/bitmaskedform.py 77.52% <0.00%> (-0.53%) ⬇️
src/awkward/_v2/forms/bytemaskedform.py 76.82% <0.00%> (-0.51%) ⬇️
src/awkward/_v2/forms/emptyform.py 74.60% <0.00%> (-5.40%) ⬇️
src/awkward/_v2/forms/form.py 81.87% <0.00%> (-8.20%) ⬇️
src/awkward/_v2/forms/indexedform.py 79.26% <0.00%> (-0.74%) ⬇️
src/awkward/_v2/forms/indexedoptionform.py 79.01% <0.00%> (-0.72%) ⬇️
... and 171 more

@ioanaif ioanaif marked this pull request as ready for review March 17, 2022 11:05
@ioanaif ioanaif requested a review from jpivarski March 17, 2022 11:05
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'll click the box that fixes the typo in the spelling of is_UnknownType.

src/awkward/_v2/operations/structure/ak_unflatten.py Outdated Show resolved Hide resolved
else:
return layout

out = transform(layout, depth=1, posaxis=axis)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping this up as a transform function that is only ever used once is now superfluous, but not harmful. In v1, it was needed so that the same procedure could be applied to each partition, but now we don't do PartitionedArrays anymore.

I also don't see a strong motivation to refactor it.

@jpivarski jpivarski enabled auto-merge (squash) March 17, 2022 19:02
@jpivarski jpivarski merged commit cd24aa3 into main Mar 17, 2022
@jpivarski jpivarski deleted the ioanaif/ak.unflatten branch March 17, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants