Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds stopped working; be looser about directory name. #1407

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

jpivarski
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1407 (7463625) into main (edfce38) will not change coverage.
The diff coverage is n/a.

@jpivarski
Copy link
Member Author

@henryiii FYI: it looks like setuptools (or some similar part of the process) updated and changed the working directory name on Windows, but not the other platforms. The reason I say that is because Windows builds started failing due to not finding a directory, and our print-outs show a different from expected name, on all except Python 3.6. Probably what happened is that the newly updated build tool only has releases for Python 3.7 and up, so that acts as a good indicator.

The temp-... directory now has a longer platform name, it includes "cpython" in its name, and it has removed the dot between major and minor Python version numbers. If this PR succeeds, I'll merge it into main and all of the affected PRs can merge from main to get it.

@jpivarski jpivarski merged commit 87cf579 into main Apr 11, 2022
@jpivarski jpivarski deleted the jpivarski/looser-about-temp-directory-name branch April 11, 2022 14:56
@jpivarski
Copy link
Member Author

FYI @swishdiff: this is done and merged.

@henryiii
Copy link
Member

This was an important fix I was pushing for (and it should have affected all systems, not just Windows); before PyPy 3.x would try to reuse CPython 3.x'd cached build (or vice versa) and break all sorts of things. It really started hitting us when PyPy was added to manylinux and cibuildwheel would build all in one job.

@henryiii
Copy link
Member

And it's in distutils which is vendored into setuptools, so yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants