fix: Ensure that ak._v2.to_json raises errors when appropriate. #1649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at
to_list
, I had some questions for myself about theto_json
code right beside it, which seemed to not raise errors on bad JSON. The mistake was in my test: v1 has been silently generating bad JSON, not v2! But anyway, here are explicit tests forto_json
error-checking so that this doesn't come up again (for v2 users).