Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use proper lengths in ByteMaskedArray.mergemany (backport) #1750

Merged
merged 2 commits into from
Sep 29, 2022
Merged

fix: use proper lengths in ByteMaskedArray.mergemany (backport) #1750

merged 2 commits into from
Sep 29, 2022

Conversation

agoose77
Copy link
Collaborator

Fixes #1747 for v1-main

@agoose77 agoose77 changed the base branch from main to main-v1 September 28, 2022 20:01
@agoose77 agoose77 closed this Sep 28, 2022
@agoose77 agoose77 reopened this Sep 28, 2022
@agoose77 agoose77 requested a review from jpivarski September 29, 2022 06:42
@jpivarski
Copy link
Member

I'll be testing this in Ian's original issue, to verify that it fixes it.

jpivarski
jpivarski approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the fact that this is the backport PR of a PR I've already accepted and merged.

@jpivarski jpivarski merged commit f2092ee into main-v1 Sep 29, 2022
@jpivarski jpivarski deleted the agoose77/fix-bytemaskedarray-mergemany-regression-backport branch September 29, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: reading parquet file leads to ByteMaskedArray length error
2 participants
@agoose77 @jpivarski