Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ak._util #1848

Merged
merged 4 commits into from
Oct 31, 2022
Merged

refactor: ak._util #1848

merged 4 commits into from
Oct 31, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 31, 2022

This is a small PR to refactor ak._util. Visibly,

  • remove ak._util.isstr
  • rename ak._util.isint with ak._util.is_integer

This is refactoring work that was motivated by other PRs.


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-refactor-ak-util/ once Read the Docs has finished building 🔨

@agoose77 agoose77 requested a review from jpivarski October 31, 2022 10:43
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The is_integer is a better name, and it's good to be fully on board with isinstance(·, str) in the Python 3 world.

@jpivarski jpivarski merged commit fec5eee into main Oct 31, 2022
@jpivarski jpivarski deleted the agoose77/refactor-ak-util branch October 31, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants