Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run PR job on main #1853

Merged
merged 1 commit into from
Oct 31, 2022
Merged

ci: don't run PR job on main #1853

merged 1 commit into from
Oct 31, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 31, 2022


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-ci-fix-deploy-main/ once Read the Docs has finished building 🔨

@agoose77
Copy link
Collaborator Author

I missed something in the last PR (note-to-self, when you assume, you make an ass out of u and me). This fixes the last approved PR, so I'm happy to merge without a second pair of eyes.

@agoose77 agoose77 enabled auto-merge (squash) October 31, 2022 20:13
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1853 (a0da7a1) into main (a7e4ef6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/indexedarray.py 76.60% <0.00%> (-0.19%) ⬇️
src/awkward/contents/recordarray.py 83.87% <0.00%> (-0.19%) ⬇️
src/awkward/_util.py 82.21% <0.00%> (-0.18%) ⬇️
src/awkward/contents/indexedoptionarray.py 88.90% <0.00%> (-0.16%) ⬇️
src/awkward/_connect/avro.py 87.17% <0.00%> (-0.14%) ⬇️
src/awkward/types/_awkward_datashape_parser.py 47.72% <0.00%> (-0.01%) ⬇️

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's fine. Some of these I review as, "I don't know how the docs/CI system works, but I can see that the output is right." I had thought that the qualifier for the last one was that the docs were generated.

@agoose77 agoose77 merged commit eb87963 into main Oct 31, 2022
@agoose77 agoose77 deleted the agoose77/ci-fix-deploy-main branch October 31, 2022 20:35
@agoose77
Copy link
Collaborator Author

Looks like it succeeded (at least the build triggers!)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants