-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: run deploy for PR #1891
wip: run deploy for PR #1891
Conversation
Codecov Report
Additional details and impacted files |
@jpivarski this commit tested the deployment for Python, whilst this commit tested the C++. I installed the wheels using cd $(mktemp-d)
python3 -m venv .venv
source .venv/bin/activate
# Populate wheels
mkdir wheels
python3 -m pip wheel packaging numpy pyparsing -w ./wheels
unzip <PATH-TO-CPP-WHEELS> -d wheels
unzip <PATH-TO-PY-WHEELS> -d wheels
# Install awkward
python3 -m pip install --pre awkward --find-links=./wheels --no-index
# Test
python3 -c "import awkward as ak; builder=ak.ArrayBuilder();builder.integer(100);print(builder.snapshot())" which succeeded. I was also able to build a C++ wheel from the C++ sdist, which passed the We can just merge this by skipping tests if you're happy to merge; we don't touch anything about from the deployment CI, which doesn't run in the test suite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve!
name: "Make SDist" | ||
name: Make SDist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started indiscriminately quoting strings in YAML after being burned by some cases that looked like strings but weren't, due to some special character. It never hurts to quote. I don't think it's harder to read with quotes.
This one can be unquoted, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have the same philosophy. The Python versions always catch me out. I chose to make things look more uniform, but when writing new YAML I usually always quote.
- name: Compute SOURCE_DATE_EPOCH | ||
shell: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's new to me. I guess you opted for Python as a shell because to use strip()
. There's probably a shell equivalent, but why bother? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'd rather not use Python! But, we run this on all OSs, and the Python implementation easily works on all platforms. We might want to make this a dev script, I'm half minded.
502023f
to
843886d
Compare
📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-ci-fix-deploy-workflow/ once Read the Docs has finished building 🔨