Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ak_from_parquet #1977

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: ak_from_parquet #1977

merged 1 commit into from
Dec 8, 2022

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Dec 8, 2022

This PR fixes #1973

The issue came from parameters miss-match.

The use-case from the issue was tested locally:

>>> import awkward as ak
>>> import dask_awkward as dak
>>> ds = dak.from_parquet("s3://ddavistemp/higgs_pq/*.parquet", storage_options={"anon": True})
>>> dak.to_parquet(ds, "outputs")
>>> ak.from_parquet("outputs")
<Array [{run: 1, ...}, ..., {run: 1, ...}] type='299683 * {run: int64, lumi...'>

cc @jpivarski


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/ioanaif-fix-ak-from-parquet/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1977 (276d448) into main (8273e2e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/operations/ak_from_parquet.py 89.39% <ø> (ø)

@ioanaif ioanaif requested a review from jpivarski December 8, 2022 16:15
@jpivarski jpivarski merged commit f99ad83 into main Dec 8, 2022
@jpivarski jpivarski deleted the ioanaif/fix-ak-from-parquet branch December 8, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ak.from_parquet for multiple files uses wrong number of arguments to concatenate
2 participants