Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update backport for changes in Numba, NumExpr, Arrow, and RDataFrame #2735

Merged
merged 16 commits into from
Oct 4, 2023

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Oct 4, 2023

address issue #2734

@jpivarski
Copy link
Member

With or without this PR (that is, main-v1 or ianna/numba-error-backport-to-v1), I get 66 test failures. They might not be related to Numba. I'm going to work through the test failures to see what can be done.

@jpivarski jpivarski changed the title fix: backport numba old to new style error capturing to avoid warnings fix: update backport for changes in Numba, NumExpr, Arrow, and RDataFrame Oct 4, 2023
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm self-reviewing this because I don't think there's anything a second pair of eyes can add.

After merging this into main-v1, I'll also publish a release as 1.10.5.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main-v1@e68a046). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 084f90e differs from pull request most recent head 4492cdc. Consider uploading reports for the commit 4492cdc to get more accurate results

Additional details and impacted files

@jpivarski
Copy link
Member

I know that the Windows 32-bit wheels build and are successfully tested from those builds.

https://github.com/scikit-hep/awkward/actions/runs/6410147455/job/17402806110?pr=2735

There is no reason to struggle with build-test.yml, to get its Windows to see the correct version of Python when wheels.yml does it correctly.

So I'll just remove the 32-bit test from build-test.yml and merge.

@jpivarski jpivarski linked an issue Oct 4, 2023 that may be closed by this pull request
@jpivarski jpivarski merged commit cf8f373 into main-v1 Oct 4, 2023
@jpivarski jpivarski deleted the ianna/numba-error-backport-to-v1 branch October 4, 2023 20:15
@ianna
Copy link
Collaborator Author

ianna commented Oct 7, 2023

I like the −68,438 :-)

@jpivarski
Copy link
Member

Oh yeah, I ran into a few problems with v2 tests failing, and this is v1, so I just dropped all of the tests. In principle, I could drop the awkward._v2 source code as well, but I didn't do that because I wasn't sure whether it would break anything. (I'd have to look more closely.)

You had me wondering, for a moment, whether there was an integer wrap-around error, since -68,438 looks a bit like -2**16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awkward version 1.x has a conflict (just a warning?) with Numba 0.53
2 participants