-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update backport for changes in Numba, NumExpr, Arrow, and RDataFrame #2735
Conversation
With or without this PR (that is, |
…g because it's correct in the real Awkward 2.x
…/scikit-hep/awkward into ianna/numba-error-backport-to-v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm self-reviewing this because I don't think there's anything a second pair of eyes can add.
- @ianna updated all Numba errors to
NumbaTypeError
andNumbaValueError
, like fix: usingnumba.core.errors.Numba<Error>
instead ofError
in a Numba typing context. #2659. - I updated our NumExpr interface like fix: adjust for numexpr 2.8.5, which hid getContext's frame_depth argument #2617.
- I updated our pyarrow-Parquet interface to allow
.list.element
in addition to.list.item
, similar to fix: update string to search for in determing parquet column list separator #2670. - I dropped failing RDataFrame tests without investigating why they were failing. This is only in the
_v2
subdirectory, which no one should be using now: the 1.x backport is for using 1.x. If anyone is using 2.x interfaces, they should be using Awkward 2.x.
After merging this into main-v1
, I'll also publish a release as 1.10.5.
Codecov Report
Additional details and impacted files |
I know that the Windows 32-bit wheels build and are successfully tested from those builds. https://github.com/scikit-hep/awkward/actions/runs/6410147455/job/17402806110?pr=2735 There is no reason to struggle with build-test.yml, to get its Windows to see the correct version of Python when wheels.yml does it correctly. So I'll just remove the 32-bit test from build-test.yml and merge. |
I like the −68,438 :-) |
Oh yeah, I ran into a few problems with v2 tests failing, and this is v1, so I just dropped all of the tests. In principle, I could drop the You had me wondering, for a moment, whether there was an integer wrap-around error, since -68,438 looks a bit like |
address issue #2734