fix: performance of ufunc resolution for non-nominal signatures #3030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lgray observed that
find_ufunc
is a significant bottleneck in coffea-dask workflows. Whilst we can optimise this further by changing our internal representation of behaviors (i.e.__getitem__
registers overloads in high-performance lookup structures), for now I suspect that we can improve the performance of the common-path. @jpivarski notes that the behaviour changed in this PR was never intended to be supported, so it represents a correctness improvement regardless.The case that this PR improves is
np.add(foo, bar, ...)
where neitherfoo
norbar
are Awkward Arrays with names (e.g.__record__
). This represents most ufunc operations given that even ufunc overloads of records often delegate to Awkwards' ufunc mechanism on arrays of numbers.