fix: refine the implementation of copy_behaviors #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saransh-cpp
force-pushed
the
fix-copy_behaviors
branch
from
b5ec9d6 to
6c79999
Compare
|
For discussion:
Originally posted by @nsmith- in #3137 (comment) |
jpivarski
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Great, thanks! I remember that this was the solution we discussed. It changes the way copy_behaviors works, but it's a new enough function (and you're the only user), so that backward incompatibility is not going to be an issue.
This PR is ready to be merged, as-is. When you're done, go ahead and merge it!
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.