Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requesting layout.form should not touch shape #3189

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

jpivarski
Copy link
Member

@martindurant
Copy link
Contributor

Is awkward main still compatible with the last awkward-cpp, so that I can install this simply without recompiling?

@martindurant
Copy link
Contributor

I was also going to comment "wow, so many lines", but I see it's all tests for the different classes.

@jpivarski
Copy link
Member Author

Is awkward main still compatible with the last awkward-cpp, so that I can install this simply without recompiling?

I think so. I'm testing against main here: https://github.com/scikit-hep/awkward/actions/runs/10163112284

And testing against pivarski/requesting_form_should_not_touch_shape here: https://github.com/scikit-hep/awkward/actions/runs/10163115961

Oh, apparently not. Let me see if I can get a new awkward-cpp into PyPI today.

@jpivarski
Copy link
Member Author

A new version of awkward-cpp is available. You can just pip-install it.

@martindurant
Copy link
Contributor

This seems to work as intended.
I still don't know how to solve the concat case, though - we can talk about that separately.

@agoose77
Copy link
Collaborator

I like this! It makes sense that we don't need any shape-content information to know that the inner_shape is () -- the dimension is a form-level thing.

@jpivarski jpivarski enabled auto-merge (squash) July 31, 2024 16:25
@jpivarski jpivarski merged commit 39541db into main Jul 31, 2024
40 checks passed
@jpivarski jpivarski deleted the pivarski/requesting_form_should_not_touch_shape branch July 31, 2024 16:39
pfackeldey pushed a commit to pfackeldey/awkward that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants