-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add cuda backend support for to_raggedtensor
and from_raggedtensor
functions
#3263
fix: add cuda backend support for to_raggedtensor
and from_raggedtensor
functions
#3263
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
@jpivarski while trying to make the
However if try to do the same with the
Should I make the function use a TensorFlow policy and automatically select a device or create some kind of workaround? |
If this is not possible and TensorFlow returns an object whose backend depends on what hardware is available (a terrible practice! shame on TensorFlow!), then we'll have to explain that (apologetically) in our documentation. |
…r-raggedtensor-conversions
…or-raggedtensor-conversions' into maxymnaumchyk/add-cuda-support-for-raggedtensor-conversions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I added some possible changes—actually, "things to think about" because you know the TensorFlow situation better than I do.
This could also use tests. Would it be sufficient to copy the to/from raggedtensor tests from the tests/ directory to tests-cuda/ and replace NumPy arrays with CuPy arrays?
Just as you can run the normal tests with
python -m pytest tests
you can run the CUDA tests with
python -m pytest tests-cuda
on a computer with an Nvidia GPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good! Except maybe for the case of more than 10 GPUs: see below. Once that's fixed, this would be ready to merge.
No description provided.