Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test from_raggedtensor on CUDA #3298

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: test from_raggedtensor on CUDA #3298

merged 1 commit into from
Nov 8, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Nov 8, 2024

Use a consistent back-end for comparison.

@ianna
fix: test from_raggedtensor on CUDA
6c8a867 
Use a consistent back-end for comparison.
ianna
ianna commented Nov 8, 2024
View reviewed changes
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how I missed it :-)

@ianna ianna requested a review from jpivarski November 8, 2024 07:08
jpivarski
jpivarski approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good test and I will merge it. Thanks!

@jpivarski jpivarski merged commit 6c47e1d into main Nov 8, 2024
41 checks passed
@jpivarski jpivarski deleted the ianna/fix_from_raggedtensor_test_on_cuda branch November 8, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianna @jpivarski