Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python SyntaxWarning #349

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix Python SyntaxWarning #349

merged 1 commit into from
Jul 23, 2020

Conversation

reikdas
Copy link
Collaborator

@reikdas reikdas commented Jul 23, 2020

No description provided.

@reikdas reikdas requested a review from jpivarski July 23, 2020 10:32
jpivarski
jpivarski approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! That's right—we don't want to compare strings by reference.

@jpivarski jpivarski merged commit 61f0ab5 into master Jul 23, 2020
@jpivarski jpivarski deleted the reikdas/fix-warning branch July 23, 2020 11:41
@ianna
Copy link
Collaborator

ianna commented Jul 23, 2020

Thanks @reikdas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reikdas @ianna @jpivarski