Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: check for file-like objects in from_parquet #923

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Bugfix: check for file-like objects in from_parquet #923

merged 3 commits into from
Jun 15, 2021

Conversation

agoose77
Copy link
Collaborator

This doesn't fully address the larger changes that we probably need to make w.r.t #886, but does fix #921.

Perhaps this is a good stop-gap fix until we address the larger changes.

jpivarski
jpivarski approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an important oversight. (I didn't realize that file-like objects could be iterable.) Thanks!

If you're all done (thumbs up/checkmark), I'll merge it.

@jpivarski jpivarski merged commit 2590928 into main Jun 15, 2021
@jpivarski jpivarski deleted the bugfix-from-parquet-file-like branch June 15, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

from_parquet does not work with file-like objects
2 participants
@agoose77 @jpivarski