Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix loading from any directory #953

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

henryiii
Copy link
Member

The tests wouldn't run from inside the directory.

@henryiii
Copy link
Member Author

PS: As a safety feature, cibuildwheel runs from a different directory, so that doesn't pick up a local copy by accident. But the current form of the tests require only running from one directory (the repo directory). This enables them to be run anywhere.

@jpivarski
Copy link
Member

Only one test file assumed a directory? I'm surprised. But if the tests pass from a different directory, then that must have been it.

Thanks!

@jpivarski jpivarski merged commit 4168ceb into scikit-hep:main Jun 24, 2021
@henryiii
Copy link
Member Author

Note I am not running with any extras, like numba, etc, so this was just for the basic tests. (Adding a few extras might not be a bad idea, but we'll start with this).

@henryiii henryiii deleted the henryiii/fix/loading branch June 24, 2021 14:56
This was referenced Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants