C++ refactoring: convert and compare v1 and v2 arrays; renamed v2 recordarray -> keys. #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ordarray -> keys.
jpivarski
added a commit
that referenced
this pull request
Jan 13, 2022
jpivarski
added a commit
that referenced
this pull request
Jan 13, 2022
* Through test_0084-start-unionarray.py. * Through test_0093-simplify-uniontypes-and-optiontypes.py. * Through test_0093-simplify-uniontypes-and-optiontypes.py. * Through test_0111-jagged-and-masked-getitem.py. * Done through test_0115-generic-reducer-operation.py. * Done through test_0150-flatten.py. * Done through test_0224-arrow-to-awkward.py. * Done through test_0449-merge-many-arrays-in-one-pass.py. * Done through test_0499-getitem-indexedarray-bug.py. * Done through test_0557-min-max-initial-argument.py. * Done through test_0593-preserve-nullability-in-arrow-and-parquet.py. * Done with all but a few. * Done through test_0835-datetime-type.py. * Done through test_0875-arrow-null-type.py. * Done through test_0927-numpy-array-nbytes.py. * Drop test #962 entirely; it checks v1_to_v2, which will go away. * Done through test_1031-start-getitem_next.py. * Done through test_1031b-start-getitem_next-specialized.py. * Done through test_1059-localindex.py. * Done through test_1072-sort.py. * Done through test_1074-combinations.py. * Done through test_1075-validityerror.py. * Done through test_1116-project-maskedarrays.py. * Done through test_1132-utility-methods-for-highlevel-functions.py. * Done through test_1137-num.py. * Done through test_1142-numbers-to-type.py. * Removed all references to ak.layout in tests/v2. * Removed all references to ak.Array in tests/v2. * Removed all ak.this and ak.that in tests/v2. Done with PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.