Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow build system to be set to C++17, rename multithread var #502

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Feb 11, 2021

Fix #501

Support setting C++ mode in setuptools or CMake. Use the CMake naming for parallel threading. CPython 3.8 compiles in C++17 mode.

Not bothering to fix Travis because I'll be dumping it in #474 and want to avoid the merge conflict. The Conda recipe will need an update, though.

@henryiii
Copy link
Member Author

Weird. Fixed, anyway, but might be an issue in pybind11, it should not be mixing a class and a subclass, especially only on C++17. Reproduced locally with Clang, as well.

@henryiii henryiii enabled auto-merge (rebase) February 11, 2021 17:29
@henryiii henryiii added this to the 0.13.0 milestone Feb 11, 2021
@henryiii
Copy link
Member Author

henryiii commented Feb 11, 2021

The issue is pybind11 doesn't support binding noexcept methods in C++17 mode. The lambda is the correct workaround for now until someone fills out the combinatorics of adding this, or finds a better way to do it.

@henryiii henryiii merged commit def57cf into develop Feb 11, 2021
@henryiii henryiii deleted the fix/cpp17 branch February 11, 2021 18:04
@henryiii henryiii removed the needs changelog Might need a changelog entry label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Make it compatible with C++17 and newer
1 participant