-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more flexible filter specification to allow overriding and appending to filters #310
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 2023 2032 +9
Branches 331 335 +4
=========================================
+ Hits 2023 2032 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4277b20
to
e15555b
Compare
e15555b
to
01f7602
Compare
01f7602
to
d9813f8
Compare
3005587
to
19ff3e8
Compare
19ff3e8
to
95d5edc
Compare
…ough routing and template builder
… general config dict
95d5edc
to
729a5d8
Compare
This implements a new approach for filter specification outlined in #307 (comment).
Breaking changes:
Filter
option in configs is replaced byFilters
, which takes a dictionary instead of a stringFilters
needs a user-defined name (Name
property) and the filter itself (a string, asFilter
)to-do:
apply_to_all_templates
, or whether to wrap required info like currently done with ntuple and histogram paths (if not, that should probably be refactored in a second step)resolves #307