Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SamplePath overrides for histogram inputs #437

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Sep 19, 2023

As discussed in #435 and originally via #433, SamplePath overrides are needed to provide additional flexibility for histogram inputs. This adds support for such overrides. For easier debugging, a new DEBUG level message is also added to report the location of histogram and ntuple inputs.

* support SamplePath overrides when using histogram inputs
* update documentation for histogram inputs
* add debug-level log message with paths to ntuple and histogram inputs

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2b7c091) 100.00% compared to head (7ba0e62) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #437   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2071      2082   +11     
  Branches       338       340    +2     
=========================================
+ Hits          2071      2082   +11     
Files Changed Coverage Δ
src/cabinetry/templates/builder.py 100.00% <ø> (ø)
src/cabinetry/contrib/histogram_creator.py 100.00% <100.00%> (ø)
src/cabinetry/contrib/histogram_reader.py 100.00% <100.00%> (ø)
src/cabinetry/templates/collector.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-held alexander-held merged commit c7301b4 into master Sep 19, 2023
7 checks passed
@alexander-held alexander-held deleted the feat/histogram-samplepath-override branch September 19, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant