-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new dask methods #926
feat: use new dask methods #926
Conversation
9a480aa
to
912d006
Compare
@agoose77 this is in the right direction but there's one big problem in that now iterated repro: from coffea.nanoevents import NanoEventsFactory
events = NanoEventsFactory.from_root(
"tests/samples/nano_dy.root:Events",
).events()
events.Jet.matched_muons.matched_jet now fails with:
|
Still running into some regressions:
results in a couple failed tests with:
and
Which were not encountered before! |
@agoose77 ok this last edit gets rid of all the regressions on my side. |
OK, let's look to merging this in dask-awkward, then :) |
@agoose77 is there any way we can make it so I don't have to repeat functions like metadata that access awkward-array information but don't need dask? That seems rather pesky. |
@lgray sure! Let me think about it. |
@lgray try this (with new dask-awkward in my branch) |
all green in local tests. |
Once all that gets merged I'll finally switch nanoevents to use transient attrs and can get rid of that nasty copyreg I use right now. Woo. |
Leverages dask-contrib/dask-awkward#409