Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add CXXFLAGS and LDFLAGS handling for aarch64 macOS #317

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

build: Add CXXFLAGS and LDFLAGS handling for aarch64 macOS #317

wants to merge 7 commits into from

Commits on Sep 16, 2024

  1. build: Add CXXFLAGS and LDFLAGS handling for aarch64 macOS

    @matthewfeickert
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    992874b View commit details
    Browse the repository at this point in the history

  2. ci: Add aarch64 macOS to CI matrix 

    * Add 'macos-latest' runners which are macos-14 aarch64 machines.
* Add libtool to brew install list.
    @matthewfeickert
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    65f9cc9 View commit details
    Browse the repository at this point in the history

  3. ci: Add aarch64 macOS wheel builds 

    * Add macos-14 runners for auto64 archs.
* Add libtool to brew install list.
    @matthewfeickert
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    700458b View commit details
    Browse the repository at this point in the history

  4. fix: remove enable-cgal 

    From ./configure --help:

```
  --enable-cgal           enables link with the CGAL library default=no
  --enable-cgal-header-only   enable build with header-only install of CGAL, e.g. as for CGALv5; in that case do not use --enable-cgal default=no
```
    @matthewfeickert
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e600b66 View commit details
    Browse the repository at this point in the history

  5. Try to get building without extra env copy

    @matthewfeickert
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e905d59 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Remove manipulation of CXXFLAGS and LDFLAGS

    @matthewfeickert
    matthewfeickert committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f188ffd View commit details
    Browse the repository at this point in the history

  2. Revert "fix: remove enable-cgal" 

    This reverts commit e600b66.
    @matthewfeickert
    matthewfeickert committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bc648c2 View commit details
    Browse the repository at this point in the history