Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wrong plotting was triggered #247

Merged
merged 2 commits into from
Jun 30, 2021
Merged

feat: wrong plotting was triggered #247

merged 2 commits into from
Jun 30, 2021

Conversation

amangoel185
Copy link
Collaborator

Fixes #201

  • Checks over more traits to ensure correct axes
  • Add mock tests to verify the plot being triggered

@LovelyBuggies LovelyBuggies changed the title fix: wrong plottting was triggered feat: wrong plottting was triggered Jun 30, 2021
@LovelyBuggies LovelyBuggies merged commit f6a41f6 into scikit-hep:main Jun 30, 2021
@amangoel185 amangoel185 changed the title feat: wrong plottting was triggered feat: wrong plotting was triggered Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LovelyBuggies LovelyBuggies LovelyBuggies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Integer axes counts as category for plot
3 participants
@amangoel185 @LovelyBuggies @henryiii