Fix ax arg being ignored by plot_stack()
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LovelyBuggies
approved these changes
Nov 12, 2021
|
Thanks for the quick reaction and for merging this PR instead of #338, adding a changelog entry and adding me to the contributors for a duplicate effort 😅. Next time I'll take better care to check existing PR's and issues before contributing (and maybe create an issue before doing the PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ax-argument inplot_stackwasn't given to the internally calledhistplotfunction and thenaxwas overwritten with the axis in the return value ofhistplot. Instead, the argument should be forwarded.