Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make fontsize same for experiment label and secondary label for ATLAS #531

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

diptaparna
Copy link
Contributor

The font sizes for "ATLAS" and "Simulation/Internal/Preliminary" needs to be the same as per the latest ATLAS plot style.
However, in mplhep, the font size for "ATLAS" was intentionally 1.3x the font size of the secondary label.
This pull request fixes this issue.

@ntadej
Copy link

ntadej commented Oct 24, 2024

I confirm this from the ATLAS side.

Comment on lines +52 to +53
flow_th1.root
result_images/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They get created when you run pytest.

@diptaparna
Copy link
Contributor Author

Can we please merge this?

@andrzejnovak
Copy link
Member

Ok, thanks for the fix! Since I am not ATLAS, I was waiting for some contacts to corroborate the change.

@andrzejnovak andrzejnovak changed the title Make fontsize same for experiment label and secondary label for ATLAS fix: make fontsize same for experiment label and secondary label for ATLAS Oct 24, 2024
@andrzejnovak andrzejnovak merged commit be11ed5 into scikit-hep:main Oct 24, 2024
12 checks passed
@andrzejnovak
Copy link
Member

The release should appear on pypi shortly @diptaparna

@matthewfeickert
Copy link
Member

matthewfeickert commented Oct 24, 2024

Relevant details from the Style guide for ATLAS Plots:

ATLAS labels

Use the ATLAS labels if and only if your plot deserves them. Rules that govern the use of the ATLAS labels can be found in the Physics Policy Document PDF. If your plot has not been approved by ATLAS to be shown outside the Collaboration, it should not have an "ATLAS" or "ATLAS Preliminary" label.

  • The ATLAS name must be draw in Helvetica, all upper case, bold face, slanted. The ATLAS Style package provides a macro to do it.
  • Any additional text after the ATLAS name (e.g. "Preliminary") must be drawn in Helvetica normal typeface (thus, neither bold nor slanted), with first letter capitalized, in the same font size of the ATLAS name. The ATLAS Style has an example on how to properly do it.

This information would have been useful to include in the commit message itself.


Thanks for the PR @diptaparna and thanks for your first contribution to Scikit-HEP! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants