-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make fontsize same for experiment label and secondary label for ATLAS #531
Conversation
I confirm this from the ATLAS side. |
flow_th1.root | ||
result_images/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They get created when you run pytest.
Can we please merge this? |
Ok, thanks for the fix! Since I am not ATLAS, I was waiting for some contacts to corroborate the change. |
The release should appear on pypi shortly @diptaparna |
Relevant details from the Style guide for ATLAS Plots:
This information would have been useful to include in the commit message itself. Thanks for the PR @diptaparna and thanks for your first contribution to Scikit-HEP! 🎉 |
The font sizes for "ATLAS" and "Simulation/Internal/Preliminary" needs to be the same as per the latest ATLAS plot style.
However, in
mplhep
, the font size for "ATLAS" was intentionally 1.3x the font size of the secondary label.This pull request fixes this issue.