Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast, Inaccurate Mode #1056

Open
WolfgangWaltenberger opened this issue Sep 8, 2020 · 9 comments
Open

Fast, Inaccurate Mode #1056

WolfgangWaltenberger opened this issue Sep 8, 2020 · 9 comments
Labels
research experimental stuff user request Request coming form a pyhf user

Comments

@WolfgangWaltenberger
Copy link

Description

We SModelS kindly wish to propose some kind of a fast mode for pyhf, sacrificing O(10%) accuracy on the likelihoods for increase in speed. We SModelS would be interested in such a feature. And we would hope that use cases other than ours would also benefit from such a mode. We are thinking of use cases where accuracy is not the top priority. Anyways, just a proposal, just think about it! Cheers, Wolfgang, for SModelS

@lukasheinrich
Copy link
Contributor

Hi @WolfgangWaltenberger,

one thing that should be possible once we have full likelihoods is to then follow the same procedure as CMS by providing "background-integrated" covariance matrices for the various regions. We need some of the error propagation machinery needed also by @alexander-held and @ntadej which needs to go into pyhf but at that point this can be very fast at the cost precisino.

@WolfgangWaltenberger
Copy link
Author

WolfgangWaltenberger commented Sep 8, 2020 via email

@WolfgangWaltenberger
Copy link
Author

Ah Sabine reminded me of one more thing. If you go for this Gaussian-envelope approach, then we strongly recommend that you add a skewness term, or something similar to account for asymmetries. From our experience a Gaussian alone is too crude a model.

@lukasheinrich
Copy link
Contributor

yes it was always the plan that once we have the full likelihoods that the community could/would be able to develop lossy versions of it. To some extent pyhf prune which allows removing systematic terms etc makes this already possible

@matthewfeickert matthewfeickert added research experimental stuff user request Request coming form a pyhf user labels Sep 8, 2020
@sabinekraml
Copy link

Hi, may I ask what "prune" is really doing? Does it literally remove uncertainty contributions (which is not whet we want) or integrate over them?

@matthewfeickert
Copy link
Member

matthewfeickert commented Sep 18, 2020

Hi, may I ask what "prune" is really doing? Does it literally remove uncertainty contributions (which is not whet we want) or integrate over them?

The docs on pyhf.workspace.Workspace.prune probably make this the most clear, but it is just creating a new workspace (from the original you give) that has things that you specify (i.e. modifiers, samples, channels, measurements) trimmed off it.

@sabinekraml
Copy link

OK, thanks. So this is indeed not what we want for a fast mode. Instead of having things trimmed off, we'd want them to be profiled or marginalized over. That goes in the direction of the "Gaussian envelope" Wolfgang was mentioning above, but without loosing relevant asymmetries (i.e. keeping the skew).

@sabinekraml
Copy link

well, of course nuisances, which are really "irrelevant" from a fast mode point of view, may also be removed. I just want to say that it will be nice to go a bit further.

@matthewfeickert
Copy link
Member

matthewfeickert commented Sep 21, 2020

This feedback and discussion is great so far — so thanks. I think given the timescale that we want to get v0.5.3 out on we probably won't be able to get this in. We should try to follow up more on this for v0.6.0 which should be the next release after v0.5.3 and we can see if it is reasonable to get in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research experimental stuff user request Request coming form a pyhf user
Projects
Status: To do
Development

No branches or pull requests

4 participants