Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update notebooks to use include_auxdata kwarg for pyhf.Workspace.data #1588

Merged
merged 2 commits into from
Sep 4, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 4, 2021

Description

Resolves #1585

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use `include_auxdata` kwarg for `pyhf.Workspace.data` as part of v0.6.3 API change
   - Amends PR #1562

@matthewfeickert matthewfeickert added docs Documentation related fix A bug fix labels Sep 4, 2021
@matthewfeickert matthewfeickert self-assigned this Sep 4, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #1588 (ca032e6) into master (248e400) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          63       63           
  Lines        4050     4050           
  Branches      576      576           
=======================================
  Hits         3957     3957           
  Misses         54       54           
  Partials       39       39           
Flag Coverage Δ
contrib 25.43% <ø> (ø)
unittests 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248e400...ca032e6. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 173c3c7 into master Sep 4, 2021
@matthewfeickert matthewfeickert deleted the fix/fix-api-in-notebooks branch September 4, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatisticalAnalysis Notebook broken by with_aux to include_auxdata
1 participant