-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configurable default backend #1646
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
c9d2f25
move get_backend/set_backend out of init, and refactor things slightl…
kratsg 14e332d
fix some codefactors
kratsg 0df8642
use non-globals
kratsg fe576d9
flake8/lint
kratsg c531b56
dropped an import, whoops
kratsg a70b8c2
fix up optimize
kratsg 2f484f3
raise attributeerror
kratsg ec2e8f0
drop from docs/api
kratsg 08dfa02
minor fixes
kratsg bb7b26f
tests
kratsg 0606092
handle other error
kratsg b011275
Merge branch 'master' into feat/configurable-default-backend
kratsg ce6ec11
Merge branch 'master' into feat/configurable-default-backend
kratsg 5455fa3
fix up
kratsg 66ab686
fix up
kratsg 7d759f6
fix up more
kratsg 97dcde7
fix last test
kratsg 91c5419
last last last fix
kratsg 75a8978
Merge branch 'master' into feat/configurable-default-backend
kratsg 7eeeec5
make sure we test all backgrounds with default backend
kratsg 8c2ee8e
add tests to handle the use case
kratsg 8bdc252
xfail tests
kratsg 45415cf
use db=pyhf.db
kratsg 86c61fb
Merge branch 'master' into feat/configurable-default-backend
matthewfeickert 7e135e0
Update tests/test_simplemodels.py
kratsg a9c5ba1
Update tests/test_simplemodels.py
kratsg 8977db8
remove optimize from public api
kratsg 399665f
move only events up
kratsg 500d923
move import up
kratsg f01cf38
Merge branch 'master' into feat/configurable-default-backend
kratsg 972435c
wworking?
kratsg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I understand, this is necessary to avoid
because
pyhf.defaul_backend
needs to be evaluated as an attr and so doesn't exist as a static attribute? Or am I just missing the obvious here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global vs non-global. You don't want to evaluate default_backend at import time.