Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Report coverage for oldest and newest Python tested #1817

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 23, 2022

Description

Resolves #1816

  • Report coverage for the oldest Python (3.7) and newest (3.10) that are tested to ensure that version specific 'if' statements are properly covered.
  • Add Python version specific flags to the coverage reporting to compare differences in coverage and track coverage changes across versions more easily.
  • Follow up to PR feat: Alternative Schema Locations #1753

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Report coverage for the oldest Python (3.7) and newest (3.10) that are
tested to ensure that version specific 'if' statements are properly covered.
* Add Python version specific flags to the coverage reporting to compare
differences in coverage and track coverage changes across versions more easily.
* Follow up to PR #1753

@matthewfeickert matthewfeickert added tests pytest CI CI systems, GitHub Actions labels Mar 23, 2022
@matthewfeickert matthewfeickert self-assigned this Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1817 (83a7d1f) into master (2789d54) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
+ Coverage   98.02%   98.16%   +0.13%     
==========================================
  Files          68       68              
  Lines        4310     4310              
  Branches      725      725              
==========================================
+ Hits         4225     4231       +6     
+ Misses         49       46       -3     
+ Partials       36       33       -3     
Flag Coverage Δ
contrib 26.42% <ø> (ø)
doctest 60.74% <ø> (ø)
unittests ?
unittests-3.10 96.03% <ø> (?)
unittests-3.7 96.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/utils.py 94.73% <0.00%> (+5.26%) ⬆️
src/pyhf/schema/loader.py 100.00% <0.00%> (+9.52%) ⬆️
src/pyhf/schema/variables.py 100.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2789d54...83a7d1f. Read the comment docs.

@matthewfeickert matthewfeickert marked this pull request as ready for review March 23, 2022 17:57
@kratsg
Copy link
Contributor

kratsg commented Mar 23, 2022

I see flags. This looks good
Screen Shot 2022-03-23 at 11 43 14 AM

@kratsg kratsg merged commit 36e0d67 into master Mar 23, 2022
@kratsg kratsg deleted the ci/report-coverage-for-multiple-pythons branch March 23, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to cover oldest and newest Python
2 participants