Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrade jupyter-client for papermill to work #2105

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jan 30, 2023

Description

As a temporary fix to Issue #2104 (which is because of nteract/papermill#711), downgrade jupyter-client to a version less than v8.0.0 so that papermill is able to run. This is not a sufficient fix and an alternative to using papermill should be considered.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* As a temporary fix to Issue #2104, downgrade jupyter-client to a
  version less than v8.0.0 so that papermill is able to run.
  This is not a sufficient fix and an alternative to using papermill
  should be considered.

@matthewfeickert matthewfeickert added the fix A bug fix label Jan 30, 2023
@matthewfeickert matthewfeickert self-assigned this Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 98.30% // Head: 98.30% // No change to project coverage 👍

Coverage data is based on head (5568a3c) compared to base (5568a3c).
Patch has no changes to coverable lines.

❗ Current head 5568a3c differs from pull request most recent head a8769b3. Consider uploading reports for the commit a8769b3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2105   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4531     4531           
  Branches      645      645           
=======================================
  Hits         4454     4454           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <0.00%> (ø)
doctest 61.15% <0.00%> (ø)
unittests-3.10 96.31% <0.00%> (ø)
unittests-3.8 96.33% <0.00%> (ø)
unittests-3.9 96.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

Notebook tests are passing again with this:

...
collecting ... collected 12 items

tests/test_notebooks.py::test_hello_world PASSED                         [  8%]
tests/test_notebooks.py::test_xml_importexport PASSED                    [ 16%]
tests/test_notebooks.py::test_statisticalanalysis PASSED                 [ 25%]
tests/test_notebooks.py::test_shapefactor PASSED                         [ 33%]
tests/test_notebooks.py::test_multichannel_coupled_histos PASSED         [ 41%]
tests/test_notebooks.py::test_multibinpois PASSED                        [ 50%]
tests/test_notebooks.py::test_pullplot PASSED                            [ 58%]
tests/test_notebooks.py::test_impactplot PASSED                          [ 66%]
tests/test_notebooks.py::test_toys PASSED                                [ 75%]
tests/test_notebooks.py::test_learn_interpolationcodes PASSED            [ 83%]
tests/test_notebooks.py::test_learn_tensorizinginterpolations PASSED     [ 91%]
tests/test_notebooks.py::test_learn_using_calculators PASSED             [100%]
...

Screenshot from 2023-01-30 01-23-15

* As a temporary fix to Issue 2104, downgrade jupyter-client to a
  version less than v8.0.0 so that papermill is able to run.
  This is not a sufficient fix and an alternative to using papermill
  should be considered.
@matthewfeickert matthewfeickert force-pushed the fix/downgrade-jupyter-client branch from 0ec0b83 to a8769b3 Compare January 30, 2023 22:47
@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself so that the notebook tests don't time out after 6 hours tonight. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 98ae036 into main Jan 31, 2023
@matthewfeickert matthewfeickert deleted the fix/downgrade-jupyter-client branch January 31, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant