-
Notifications
You must be signed in to change notification settings - Fork 89
fix: Catch use of multi-component parameters as POI with error message #2197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
46d69ed
1046abf
c17ee02
dd011f5
e8b9b2e
2ed7648
c02a273
87a5f5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -464,10 +464,13 @@ def set_poi(self, name): | |
raise exceptions.InvalidModel( | ||
f"The parameter of interest '{name:s}' cannot be fit as it is not declared in the model specification." | ||
) | ||
s = self.par_slice(name) | ||
assert s.stop - s.start == 1 | ||
if self.param_set(name).n_parameters > 1: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This now handles |
||
# multi-parameter modifiers are not supported as POIs | ||
raise exceptions.InvalidModel( | ||
f"The parameter '{name:s}' contains multiple components and is not currently supported as parameter of interest." | ||
) | ||
self._poi_name = name | ||
self._poi_index = s.start | ||
self._poi_index = self.par_slice(name).start | ||
|
||
def _create_and_register_paramsets(self, required_paramsets): | ||
next_index = 0 | ||
|
Uh oh!
There was an error while loading. Please reload this page.