Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ruff moved to astral-sh #2238

Merged
merged 1 commit into from
Jul 3, 2023
Merged

chore: ruff moved to astral-sh #2238

merged 1 commit into from
Jul 3, 2023

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Jul 3, 2023 •
edited by matthewfeickert
Loading

See scientific-python/cookie#200.

Committed via https://github.com/asottile/all-repos

* Update Ruff pre-commit hook url to https://github.com/astral-sh/ruff-pre-commit
   - c.f. https://github.com/scientific-python/cookie/pull/200

@henryiii henryiii changed the title chore: ruff moved to astral-sh\n\nSee https://github.com/scientific-python/cookie/pull/205. chore: ruff moved to astral-sh Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (9dbdb7e) 98.30% compared to head (9b61062) 98.30%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2238   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4533     4533           
  Branches      802      802           
=======================================
  Hits         4456     4456           
  Misses         45       45           
  Partials       32       32
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.08% <ø> (ø)
unittests-3.10 ?
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert added chore Other changes that don't modify src or test files need-to-backport tmp label until can be backported to patch release branch labels Jul 3, 2023
matthewfeickert
matthewfeickert approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @henryiii!

@matthewfeickert matthewfeickert merged commit 951912f into main Jul 3, 2023
@matthewfeickert matthewfeickert deleted the all-repos_autofix_all-repos-sed branch July 3, 2023 20:35
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Aug 16, 2023
@matthewfeickert matthewfeickert mentioned this pull request Aug 16, 2023
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
@matthewfeickert
chore(backport): Move to using Ruff for pre-commit (#2282)
0744b42 
* Backport components of:
   - #2124
   - #2238
   - #2240
   - #2273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewfeickert matthewfeickert matthewfeickert approved these changes

Assignees

@henryiii henryiii

Labels
chore Other changes that don't modify src or test files
Projects
pyhf v0.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @matthewfeickert