Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backport): Use non-root default user for Docker image #2287

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

matthewfeickert
Copy link
Member

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR https://github.com/scikit-hep/pyhf/pull/2243
* Add non-root default user 'moby' with uid 1000 that owns the Python virtual environment.
   - Set default working directory to /home/moby/work/.
* Add .dockerignore for local builds.

* Backport PR https://github.com/scikit-hep/pyhf/pull/ 2243
* Add non-root default user 'moby' with uid 1000 that owns the Python virtual environment.
   - Set default working directory to /home/moby/work/.
* Add .dockerignore for local builds.
@matthewfeickert matthewfeickert added feat/enhancement New feature or request Docker Involving Docker images or builds backport Backport PRs from main to release branch labels Aug 16, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 16, 2023
@matthewfeickert matthewfeickert changed the title feat (backport): Use non-root default user for Docker image feat(backport): Use non-root default user for Docker image Aug 16, 2023
@matthewfeickert matthewfeickert merged commit 616966d into release/v0.7.x Aug 16, 2023
13 of 14 checks passed
@matthewfeickert matthewfeickert deleted the backport/docker-image branch August 16, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch Docker Involving Docker images or builds feat/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant