Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(backport): Determine tensorflow-probability requirements from python version #2491

Merged
merged 1 commit into from
May 29, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 29, 2024

Description

Backport PR #2452

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR https://github.com/scikit-hep/pyhf/pull/2452
* Split the requirements for the 'tensorflow' extra into two different
  conditional groups by python_version.
   - Starting with tensorflow v2.16.1, multiple changes were made that simplifies
   the installation of tensorflow across platform_machine and Keras v3.0 was adopted.
   - tensorflow-probability did _not_ adopt Keras v3.0, but instead requires
   tf-keras. Starting in tensorflow-probability v0.24.0 the
   'tensorflow-probability[tf]' extra was added which includes all the required
   dependencies to be able to use tensorflow-probability with tensorflow v2.15+.
   - tensorflow v2.16.1 and tensorflow-probability v0.24.0 support Python 3.9+,
   so for Python 3.8 support the 'tensorflow' requirements need to use the
   previous more verbose conditionals.

@matthewfeickert matthewfeickert added the backport Backport PRs from main to release branch label May 29, 2024
@matthewfeickert matthewfeickert self-assigned this May 29, 2024
@matthewfeickert matthewfeickert merged commit 0b5b9e5 into release/v0.7.x May 29, 2024
16 of 18 checks passed
@matthewfeickert matthewfeickert deleted the backport/tfp-support branch May 29, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant