-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Drop Python 3.8, fix issues with CI #2566
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
==========================================
+ Coverage 98.21% 98.24% +0.02%
==========================================
Files 69 69
Lines 4543 4546 +3
Branches 804 467 -337
==========================================
+ Hits 4462 4466 +4
Misses 48 48
+ Partials 33 32 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0f28a49
to
42a5249
Compare
@@ -120,7 +120,7 @@ def cdf(self, value): | |||
>>> import pyhf | |||
>>> pyhf.set_backend("numpy") | |||
>>> bkg_dist = pyhf.infer.calculators.AsymptoticTestStatDistribution(0.0) | |||
>>> bkg_dist.cdf(0.0) | |||
>>> print(bkg_dist.cdf(0.0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did something change RE: the way doctest works where the print
s are now necessary? We had always treated this like REPL behavior, not script behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, numpy changed. ubuntu-latest has numpy 2.x which gives np.float64(0.0)
while macos-13 uses numpy 1.x which gives 0.0
-- we can't write a test that relies on repr
for two diff major versions of numpy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> import numpy as np
>>> np.__version__
'2.0.2'
>>> np.float64(0.0)
np.float64(0.0)
>>> print(np.float64(0.0))
0.0
and
>>> import numpy as np
>>> np.__version__
'1.26.4'
>>> np.float64(0.0)
0.0
>>> print(np.float64(0.0))
0.0
Pull Request Description
Drop python 3.8 support (would be hard to fix most typing-related issues anyway). This will also fix maintenance issues with the CI we've been having hopefully.
Also linkcheck gives 403 for some URLs because they're blocking HEADs now... not sure why that changed.
for
academic.oup.com
for
journals.aps.org
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: