Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reading LHE files 1.0, 3.0 ; w/ & w/ out lines starting w/ #, weightgroup tag can have attribute name #132

Closed
wants to merge 1 commit into from

Conversation

UCSC-EarlAlmazan
Copy link

  • fixed bug with comment lines when reading LHE files version 3.0
  • weightgroup can have attribute type or name, which allows for reading of LHE files version 1.0
  • included version number of currently read LHE file in read_lhe_init function

…ve attribute type or name, included version number of LHEF in read_lhe_init.
@UCSC-EarlAlmazan
Copy link
Author

Seems the similarities between files before and after aren't being identified, resulting in merge conflicts.

Main changes in the new init.py are:

  • Lines 185-186 ; Reading LHE file version
  • Lines 199-203 ; alternative fix for including "name" attribute reading
  • Line 233 ; Including a check to omit lines starting with "#" when iterating over particle_objs.

@eduardo-rodrigues
Copy link
Member

eduardo-rodrigues commented Aug 26, 2022

Hello @UCSC-EarlAlmazan, I'm trying to finalise on a couple of long-standing issues and as you can see from PR #103, it fixes one of the issues you raised also. I will have more in the pipeline ... Will you be available to rebase and clean your MR up, once #103 gets merged, or else shall I go ahead and "cherry-pick" the actual improvements introduced here? It might actually be simpler to make a new and clean MR with a "cherry-pick" of the few lines that changes, which you list above. Let me know.

@eduardo-rodrigues
Copy link
Member

FYI @UCSC-EarlAlmazan I went ahead with implementing the diff in PR #139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants