Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add tests for LHEEventInfo, LHEParticle, LHEFile classes #136

Merged
merged 13 commits into from
Aug 29, 2022

Conversation

eduardo-rodrigues
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues commented Aug 25, 2022

This is all trivial at this point but is a start. It does add coverage few a few lines untested so far.

* Remove loads from API.
* Add RuntimeError message if field names are missing.
* Add tests for LHEEventInfo, LHEParticle, LHEFile classes.

@eduardo-rodrigues eduardo-rodrigues changed the title Improve test coverage - basic tests for classes LHEEventInfo, LHEParticle, LHEFile ci: Improve test coverage - basic tests for classes LHEEventInfo, LHEParticle, LHEFile Aug 25, 2022
@eduardo-rodrigues
Copy link
Member Author

The CI failures have to do with what PR #103 fixes. I will rebase as soon as the latter goes in, no worries.

@eduardo-rodrigues eduardo-rodrigues marked this pull request as ready for review August 29, 2022 16:12
@matthewfeickert
Copy link
Member

There's a pre-commit conflict here between isort and black. I can fix that in another PR with adding a profile for isort to let it know about black.

@matthewfeickert matthewfeickert added enhancement CI Continuous Integration API changes the public API labels Aug 29, 2022
@matthewfeickert matthewfeickert changed the title ci: Improve test coverage - basic tests for classes LHEEventInfo, LHEParticle, LHEFile ci: Add tests for LHEEventInfo, LHEParticle, LHEFile classes Aug 29, 2022
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 Thanks @eduardo-rodrigues!

CI is failing for known reasons which I mentioned and will fix later.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 60.28% // Head: 67.30% // Increases project coverage by +7.02% 🎉

Coverage data is based on head (572aaf3) compared to base (48f528e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   60.28%   67.30%   +7.02%     
==========================================
  Files           2        2              
  Lines         209      208       -1     
  Branches       56       56              
==========================================
+ Hits          126      140      +14     
+ Misses         73       62      -11     
+ Partials       10        6       -4     
Flag Coverage Δ
unittests-3.10 67.30% <100.00%> (+8.45%) ⬆️
unittests-3.6 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pylhe/__init__.py 74.26% <100.00%> (+8.57%) ⬆️
src/pylhe/awkward.py 35.13% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit 7859407 into master Aug 29, 2022
@matthewfeickert matthewfeickert deleted the eduardo-test-coverage-1 branch August 29, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API changes the public API CI Continuous Integration enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants