-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add tests for LHEEventInfo, LHEParticle, LHEFile classes #136
Conversation
…ep/pylhe into eduardo-test-coverage-1
The CI failures have to do with what PR #103 fixes. I will rebase as soon as the latter goes in, no worries. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
c60f99b
to
d5ebb01
Compare
There's a pre-commit conflict here between isort and black. I can fix that in another PR with adding a profile for isort to let it know about black. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 Thanks @eduardo-rodrigues!
CI is failing for known reasons which I mentioned and will fix later.
Codecov ReportBase: 60.28% // Head: 67.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 60.28% 67.30% +7.02%
==========================================
Files 2 2
Lines 209 208 -1
Branches 56 56
==========================================
+ Hits 126 140 +14
+ Misses 73 62 -11
+ Partials 10 6 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This is all trivial at this point but is a start. It does add coverage few a few lines untested so far.