Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to scikit-hep-testdata>=0.4.0 #184

Merged
merged 6 commits into from
Mar 7, 2023
Merged

Conversation

eduardo-rodrigues
Copy link
Member

As per our recent chats.

While at it, update to require a more recent version of scikit-hep-testdata in tests. Indeed scikit-hep-testdata 0.4.0 is the first release that downloads files from the git repo on demand, rather than including them all in the PyPI package. Seems reasonable to be far more lightweight in the tests.

This should be the first step toward a release 0.6.0.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f8f9d55) 88.07% compared to head (167a9f2) 88.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files           2        2           
  Lines         218      218           
  Branches       48       48           
=======================================
  Hits          192      192           
  Misses         23       23           
  Partials        3        3           
Flag Coverage Δ
unittests-3.10 87.61% <ø> (ø)
unittests-3.7 87.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @eduardo-rodrigues. Just one question RE: the vector bump.

This should be the first step toward a release 0.6.0.

Do we need to address anything else? Or could we make this a v0.6.0 release after this is merged?

We're actually already using awkward v2 in all of our tests though, as we are only placing lower bounds on it. So do we actually need to bump the awkward to v2 here until we run into a situation in which the APIs break?

setup.cfg Outdated Show resolved Hide resolved
@matthewfeickert
Copy link
Member

The CI here is breaking because of the Poetry bug that @henryiii mentioned. @henryiii can you remind me what this fix is? Just update the isort release?

@henryiii
Copy link
Member

henryiii commented Feb 4, 2023

Yes, pre-commit autoupdate will do it.

@matthewfeickert
Copy link
Member

Yes, pre-commit autoupdate will do it.

Thanks. This is done in PR #185 now.

@eduardo-rodrigues eduardo-rodrigues changed the title chore: move to Awkward 2 chore: update to scikit-hep-testdata>=0.4.0 Mar 7, 2023
@eduardo-rodrigues
Copy link
Member Author

Merging since you @matthewfeickert effectively approved already.

@eduardo-rodrigues eduardo-rodrigues merged commit c1cce28 into main Mar 7, 2023
@eduardo-rodrigues eduardo-rodrigues deleted the awkward2 branch March 7, 2023 07:48
@matthewfeickert
Copy link
Member

Thanks @eduardo-rodrigues! Should we make a v0.6.0 release for this now? Or were there additional things you wanted to get in before this?

@eduardo-rodrigues
Copy link
Member Author

There are still issues to be tackled but I can't do them just now. We could do a 0.5.2 release since nothing but hooks and an update of scikit-hep-testdata's version got updated? Up to you; no strong feeling :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants