-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to scikit-hep-testdata>=0.4.0 #184
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 2 2
Lines 218 218
Branches 48 48
=======================================
Hits 192 192
Misses 23 23
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @eduardo-rodrigues. Just one question RE: the vector
bump.
This should be the first step toward a release 0.6.0.
Do we need to address anything else? Or could we make this a v0.6.0
release after this is merged?
We're actually already using awkward
v2
in all of our tests though, as we are only placing lower bounds on it. So do we actually need to bump the awkward
to v2
here until we run into a situation in which the APIs break?
Yes, |
Thanks. This is done in PR #185 now. |
f0df3aa
to
b9aaa85
Compare
b9aaa85
to
b3a8d6d
Compare
Merging since you @matthewfeickert effectively approved already. |
Thanks @eduardo-rodrigues! Should we make a |
There are still issues to be tackled but I can't do them just now. We could do a 0.5.2 release since nothing but hooks and an update of scikit-hep-testdata's version got updated? Up to you; no strong feeling :-). |
As per our recent chats.
While at it, update to require a more recent version of
scikit-hep-testdata
in tests. Indeedscikit-hep-testdata
0.4.0 is the first release that downloads files from the git repo on demand, rather than including them all in the PyPI package. Seems reasonable to be far more lightweight in the tests.This should be the first step toward a release 0.6.0.