-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Deprecate reader API for more Pythonic style #87
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I tried removing the CODECOV_TOKEN secret to avoid the problem of the April 15th security problems, but it seems that things aren't reporting now. :/ |
Seems it is still required for uploading the coverage report:
|
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 60.69% 60.69%
=======================================
Files 2 2
Lines 201 201
Branches 36 36
=======================================
Hits 122 122
Misses 72 72
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7176cb5
to
4dc64e4
Compare
@8me, @ariaradick, @shantanu-gontia, @eduardo-rodrigues, @fuenfundachtzig, @SundeMarius, @gridge This is just a heads up that the next release of |
Revise the reader API to be more Pythonic in style as opposed to more C++/ROOT style. Example:
pylhe.readLHEWithAttributes
->pylhe.read_lhe_with_attributes
.