Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecate reader API for more Pythonic style #87

Merged
merged 6 commits into from
Apr 20, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 19, 2021

Revise the reader API to be more Pythonic in style as opposed to more C++/ROOT style. Example: pylhe.readLHEWithAttributes -> pylhe.read_lhe_with_attributes.

* Deprecate C style reader API for more Pythonic style
* Ignore flake8 warnings for E501: line too long

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@matthewfeickert
Copy link
Member Author

I tried removing the CODECOV_TOKEN secret to avoid the problem of the April 15th security problems, but it seems that things aren't reporting now. :/

@matthewfeickert
Copy link
Member Author

I tried removing the CODECOV_TOKEN secret to avoid the problem of the April 15th security problems, but it seems that things aren't reporting now. :/

Seems it is still required for uploading the coverage report:

The token below is used exclusively for uploading coverage reports.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #87 (1f8a012) into master (18d2979) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   60.69%   60.69%           
=======================================
  Files           2        2           
  Lines         201      201           
  Branches       36       36           
=======================================
  Hits          122      122           
  Misses         72       72           
  Partials        7        7           
Flag Coverage Δ
unittests 60.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pylhe/__init__.py 66.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d2979...1f8a012. Read the comment docs.

@matthewfeickert matthewfeickert force-pushed the refactor/deprecate-old-API branch from 7176cb5 to 4dc64e4 Compare April 19, 2021 17:19
@matthewfeickert matthewfeickert merged commit 7466364 into master Apr 20, 2021
@matthewfeickert matthewfeickert deleted the refactor/deprecate-old-API branch April 20, 2021 17:36
@matthewfeickert
Copy link
Member Author

@8me, @ariaradick, @shantanu-gontia, @eduardo-rodrigues, @fuenfundachtzig, @SundeMarius, @gridge

This is just a heads up that the next release of pylhe will be an API breaking change for the reader API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants