Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Revise MANIFEST.in strategy to properly use prune #95

Merged
merged 3 commits into from
Jun 19, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 19, 2021

c.f. scikit-hep/pyhf#1449 for reference and motivation

Needed for PR #94

* Use `prune **` to remove all files from the sdist
   - c.f. https://packaging.python.org/guides/using-manifest-in/#manifest-in-commands
   - "Setuptools also has undocumented support for ** matching zero or more characters including forward slash, backslash, and colon."
* Manually include all "default" files for a sdist in MANIFEST.in
   - c.f. https://packaging.python.org/guides/using-manifest-in/#how-files-are-included-in-an-sdist
* Add list of sdist contents to package publishing CI
   - Allow for easier checking of the sdist contents in CI logs

@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #95 (6f6fa97) into master (0f8af18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   60.69%   60.69%           
=======================================
  Files           2        2           
  Lines         201      201           
  Branches       36       36           
=======================================
  Hits          122      122           
  Misses         72       72           
  Partials        7        7           
Flag Coverage Δ
unittests 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8af18...6f6fa97. Read the comment docs.

@matthewfeickert matthewfeickert added the CI Continuous Integration label Jun 19, 2021
@matthewfeickert matthewfeickert merged commit 34c4b8c into master Jun 19, 2021
@matthewfeickert matthewfeickert deleted the chore/update-MANIFEST branch June 19, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant