-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more RNTuple files #151
Conversation
it may be a good idea to copy the source code to https://github.com/scikit-hep/scikit-hep-testdata/tree/main/dev/make-root and generate yourself to make sure! |
Thanks @Moelf! For |
Sorry, I just realized that that's a public file. |
oh you're right... yeah those files are a bit cryptic, indeed I had to produce them with ATLAS stuff. This is as good as it can be for the moment I think |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 69.78% 70.00% +0.21%
==========================================
Files 3 3
Lines 139 140 +1
==========================================
+ Hits 97 98 +1
Misses 42 42 ☔ View full report in Codecov by Sentry. |
I added partial instructions for how to generate these files, like in the UnROOT repo. I'll look into writing some script to generate similar test files without having to use any ATLAS tools. |
@jpivarski seems like I can't request a reviewer since I'm not a member of this repo (or scikit-hep), but this is ready for review now. |
I added three more RNTuple files that have been useful to test and debug uproot. These files were created and used by @Moelf for UnROOT testing, and can be found here.