Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more RNTuple test files #155

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

ariostas
Copy link
Collaborator

I added two more files to test RNTuple on uproot.

One of them contains std::atomic and std::bitset fields, which will be supported after scikit-hep/uproot5#1223.

The other file contains uncommon cases that the RNTuple spec supports, but we're still not sure if we will support them on uproot. This file includes a field consisting of an empty struct and another field consisting of an std::variant that is not always in a valid state.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.18%. Comparing base (9ed1610) to head (a266ce4).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   69.78%   73.18%   +3.40%     
==========================================
  Files           3        3              
  Lines         139      138       -1     
==========================================
+ Hits           97      101       +4     
+ Misses         42       37       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpivarski jpivarski merged commit 4508ba5 into scikit-hep:main Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants