Skip to content

fix: link color issue #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: link color issue #392

merged 1 commit into from
Feb 5, 2025

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Feb 5, 2025

Link color was not being set, since we were overriding the theme setting infrustructure to get light/dark mode switching. I've followed https://just-the-docs.com/docs/customization/#define-a-custom-scheme and integrated the theme color setting with our custom infrustructure.

@henryiii henryiii force-pushed the henryiii/fix/linkcolor branch from ff5374b to 4ebaac8 Compare February 5, 2025 15:41
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/linkcolor branch from 4ebaac8 to 063c067 Compare February 5, 2025 15:50
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! I reckon it looks nicer, as per our exchanges.

@henryiii henryiii merged commit cd215be into main Feb 5, 2025
1 check passed
@henryiii henryiii deleted the henryiii/fix/linkcolor branch February 5, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants