Starting the infrastructure for writing files. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…location is included in TKey::fNbytes. If ROOT resizes them, it shrink-wraps and gets the FreeSegments right. Also confirmed: fLast is the last free byte, not the first byte afterward (i.e. fFirst and fLast are both INCLUSIVE).
…rent or subdirectory and ROOT+Uproot can read them back. No errors/warnings at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make tasks like the one in #320 more abstract, less "rawbytes manipulation."
Since the file-writer also has to read data (to find out where to write), some of its functionality is duplicated with Cursors and Sources. I think that's okay: writing is fundamentally different from reading—not symmetric at all—and so the infrastructure should be semi-independent. We may (eventually) use the same Model classes for reading and writing, so that the deserialization and serialization patterns are right next to each other and therefore easier to maintain, but the more fundamental stuff with maintaining the FreeSegments structure and cascading updates through dependencies should be kept separate from the code for read-only objects.
I should also link in discussion #321, since this is a continuation of that project.