fix: cache form remapping to avoid per-chunk workload #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lgray can you check coffea against this PR to confirm no regressions? |
|
@agoose77 yep looks good on my side. |
|
Last touched 12 hours ago, I guess it's ready. I'll update to main to re-run the tests and enable auto-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #997 with a PR that exclusively caches the remapped form.
In the original dask-awkward refactoring PR, I treated form remapping as a cheap operation that could be performed multiple times. However, it appears that this was too strong an assumption, and incidentally brings other consequences when performed at worker time, not just at scheduler time.
This PR caches the form remapping, changing our private interface to store the remapping information rather than its factory.