Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constructors for VectorObject4D and MomentumObject4D #232

Merged
merged 21 commits into from
Feb 17, 2023

Conversation

Saransh-cpp
Copy link
Member

The branch for VectorObject4D was going stale on my fork. I have decided to keep this open as a draft PR and mark this ready for review once #89 and #231 are merged. This way, I can periodically check on this and keep it synced with the latest changes.

Note
This pull request is built on top of #89 and #231; hence it has the changes of #89 and #231 too. I will sync this PR once #89 and #231 are merged.

@Saransh-cpp Saransh-cpp marked this pull request as draft July 29, 2022 15:45
@Saransh-cpp Saransh-cpp added the feature New feature or request label Aug 29, 2022
@Saransh-cpp Saransh-cpp added this to the v1.0.0 milestone Aug 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Base: 83.70% // Head: 82.67% // Decreases project coverage by -1.03% ⚠️

Coverage data is based on head (9c54f3e) compared to base (b1bd185).
Patch coverage: 65.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   83.70%   82.67%   -1.03%     
==========================================
  Files          96       96              
  Lines       10787    11424     +637     
==========================================
+ Hits         9029     9445     +416     
- Misses       1758     1979     +221     
Impacted Files Coverage Δ
src/vector/backends/object.py 74.85% <52.85%> (-0.98%) ⬇️
src/vector/_methods.py 74.34% <66.66%> (-3.61%) ⬇️
src/vector/backends/numpy.py 80.00% <66.66%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Saransh-cpp Saransh-cpp marked this pull request as ready for review February 17, 2023 07:25
@henryiii henryiii merged commit 9310cd4 into scikit-hep:main Feb 17, 2023
@Saransh-cpp Saransh-cpp deleted the saransh/4D-object-constructors branch February 17, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants