Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: _marching_cubes_lewiner_cy: mark char as signed #3587 #3678

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

hmaarrfk
Copy link
Member

Fix marching_cubes_lewiner on ppc64le

Closes gh-2982.

Description

[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[For detailed information on these and other aspects see scikit-image contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]

For reviewers

(Don't remove the checklist below.)

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@hmaarrfk hmaarrfk changed the title bacport: _marching_cubes_lewiner_cy: mark char as signed #3587 backport: _marching_cubes_lewiner_cy: mark char as signed #3587 Jan 25, 2019
@soupault
Copy link
Member

soupault commented Jan 25, 2019

@hmaarrfk Could you update your branch and rebase, please? The Travis builds are beyond red 😄.

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #3678 into v0.14.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.14.x    #3678   +/-   ##
========================================
  Coverage    86.57%   86.57%           
========================================
  Files          337      337           
  Lines        27570    27570           
========================================
  Hits         23868    23868           
  Misses        3702     3702

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0671b...dfcd774. Read the comment docs.

@hmaarrfk
Copy link
Member Author

done!

@soupault
Copy link
Member

... Now it's failing because of Dask. At least, something is green.

@soupault soupault merged commit e92746f into scikit-image:v0.14.x Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants