Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tools: Set astropy minimum requirement to 1.2 to help the CIs. #3767

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

hmaarrfk
Copy link
Member

Description

Not too sure astropy was ever installed successfully.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@hmaarrfk
Copy link
Member Author

hmaarrfk commented Feb 24, 2019

@scikit-image/core fun fun, the pip quiet flag also fails silently ;) seems like astropy upgraded. We need to find an "older version" of astropy that we want to include in our minimum requirements pinnings.

https://travis-ci.org/scikit-image/scikit-image/jobs/497867990#L2071

@stefanv
Copy link
Member

stefanv commented Feb 24, 2019

Feel free to pick one and move on. I think we only use this to test our fits plugin.

@hmaarrfk hmaarrfk changed the title Remove quiet flags from pip install Set astropy minimum requirement to 1.2 to help the CIs. Feb 25, 2019
@hmaarrfk
Copy link
Member Author

hmaarrfk commented Feb 25, 2019

I was able to use astropy 1.0 to import pyfits. astropy 0.4 didn't install on my system (being very descriptive here).

Astropy 1.2 has wheels python 2.7 and 3.5, so I think that is the best thing to do for our CIs and backport.

Astropy 1.3 has wheels for 3.6 too.

@hmaarrfk hmaarrfk requested review from stefanv and jni February 25, 2019 04:13
@hmaarrfk hmaarrfk mentioned this pull request Feb 25, 2019
9 tasks
@sciunto sciunto merged commit 86904cf into scikit-image:master Feb 25, 2019
@hmaarrfk
Copy link
Member Author

@meeseeksdev backport to v0.14.x

@hmaarrfk hmaarrfk deleted the was_astropy_ever_installed branch February 26, 2019 04:33
meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Feb 26, 2019
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 26, 2019

Something went wrong ... Please have a look at my logs.

soupault added a commit that referenced this pull request Feb 26, 2019
…7-on-v0.14.x

Backport PR #3767 on branch v0.14.x (Set astropy minimum requirement to 1.2 to help the CIs.)
@jni jni mentioned this pull request Feb 26, 2019
3 tasks
@hmaarrfk hmaarrfk changed the title Set astropy minimum requirement to 1.2 to help the CIs. Build tools: Set astropy minimum requirement to 1.2 to help the CIs. Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants